Merge jammy#583
Conversation
In https://lists.ubuntu.com/archives/jammy-changes/2024-September/033387.html it says: " Packaging restructuring: - Split netplan-generator into separate package to make the Python dependency optional. - Split python3-netplan bindings into a separate package" Newer Azure builds pull in this new netplan version due to cloud-init. It does not seem like there are any functional changes that we care about. ai-assisted=yes [TNZ-88995]
We don't really ever want these builds to stack up, and I believe the attempts: 3 just lead to longer failure cycles. ai-assisted=yes [TNZ-88995]
Include netplan refactor packages in Azure dpkg list
…uilder Serialize stemcell builds, and remove attempts
The new error checking was finding errors. Going back to the old code which did not check for errors but did work for teams. Jammy-on-Jammy -on-Garden is a pretty niche use case these days, so this seems ok.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
- set explicitly in pipeline config
- delete unused *.meta4 files - delete *.meta4 files for unsupported stemcells
Remove conditional path in CI that could download the OS_IMAGE using `meta4 file-download`. Remove rake tasks which supported this path, and remove references from docs.
Move metalink files to repo root
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
Updates the stemcell build pipeline and tooling to rely on pre-built OS image tarballs (via metalinks) and aligns metalink locations/filenames across CI, docs, and pipeline configuration.
Changes:
- Add new OS image metalink files for Ubuntu Jammy and Noble under
image-metalinks/. - Simplify stemcell build flow to require an explicit
os_image_pathand remove the “download remote OS image” rake tasks/branches. - Update CI pipeline/task configuration to use the repo-root
image-metalinks/layout and adjust meta4 naming (incl. agent suffix).
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| image-metalinks/ubuntu-noble/ubuntu-noble.meta4 | Adds Noble OS image + USN log metalink for CI consumption. |
| image-metalinks/ubuntu-jammy/ubuntu-jammy.meta4 | Adds Jammy OS image + USN log metalink for CI consumption. |
| ci/tasks/os-images/build.sh | Adjusts OS image build task ownership/setup and simplifies directory handling. |
| ci/tasks/build.yml | Makes os-image-tarball input required for stemcell build task. |
| ci/tasks/build.sh | Switches to always building with a provided OS image tarball input. |
| ci/tasks/build-release-metadata.sh | Updates metalink path to repo-root image-metalinks/ layout. |
| ci/pipelines/builder.yml | Updates metalink resource URI/path and meta4 naming to include agent suffix; ignores new metalinks path. |
| bosh-stemcell/spec/assets/dpkg-list-ubuntu-azure-additions.txt | Updates expected Azure package additions list. |
| bosh-stemcell/image-metalinks/ubuntu_noble_poc/ubuntu-noble.meta4 | Removes obsolete Noble POC metalink file. |
| Rakefile | Removes remote OS image download tasks; makes stemcell:build require an os_image_path argument. |
| README.md | Updates local build instructions to use stemcell:build with an OS image path. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
NOTE: need to re-configure pipeline